Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.8] 🌱 Refactor test data to align with core CAPI #2264

Merged
merged 1 commit into from
Aug 22, 2023
Merged

[release-1.8] 🌱 Refactor test data to align with core CAPI #2264

merged 1 commit into from
Aug 22, 2023

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon [email protected]

Manual cherry-pick of #2250

Part of #2251

@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Aug 21, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 21, 2023
@killianmuldoon
Refactor test data to align with core CAPI
a126bc2 
Signed-off-by: killianmuldoon <[email protected]>

(cherry picked from commit 96f02b7)
@killianmuldoon
Copy link
Contributor Author

/test

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-conformance-release-1-8
  • /test pull-cluster-api-provider-vsphere-e2e-full-release-1-8
  • /test pull-cluster-api-provider-vsphere-e2e-release-1-8
  • /test pull-cluster-api-provider-vsphere-test-integration-release-1-8
  • /test pull-cluster-api-provider-vsphere-test-release-1-8
  • /test pull-cluster-api-provider-vsphere-verify-release-1-8

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-release-1-8

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-apidiff-release-1-8
  • pull-cluster-api-provider-vsphere-e2e-release-1-8
  • pull-cluster-api-provider-vsphere-test-integration-release-1-8
  • pull-cluster-api-provider-vsphere-test-release-1-8
  • pull-cluster-api-provider-vsphere-verify-release-1-8

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-provider-vsphere-e2e-full-release-1-8

killianmuldoon
killianmuldoon commented Aug 21, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-cluster-api-provider-vsphere-e2e-full-release-1-8

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1c69ca743e316093f280a21af67bdffe4b18f078

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 578f6c8 into kubernetes-sigs:release-1.8 Aug 22, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gab-satchi gab-satchi Awaiting requested review from gab-satchi

@vrabbi vrabbi Awaiting requested review from vrabbi

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@killianmuldoon @k8s-ci-robot @sbueringer